Browse Source

Fix #59: add yet another special case to handle the spec being lies

George S. Baugh 5 months ago
parent
commit
e974d94c01
4 changed files with 9 additions and 4 deletions
  1. 2 2
      README.md
  2. 1 1
      dist.ini
  3. 1 1
      package.json
  4. 5 0
      playwright_server

+ 2 - 2
README.md

@@ -50,8 +50,8 @@ From there you'll need nvm to get the latest verison of node working:
 
 
     wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
     wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
     source ~/.bashrc
     source ~/.bashrc
-    nvm install
-    nvm use
+    nvm install node
+    nvm use node
 
 
 Running dzil test should let you know if your kit is good to develop.
 Running dzil test should let you know if your kit is good to develop.
 
 

+ 1 - 1
dist.ini

@@ -1,5 +1,5 @@
 name = Playwright
 name = Playwright
-version = 1.324
+version = 1.401
 author = George S. Baugh <george@troglodyne.net>
 author = George S. Baugh <george@troglodyne.net>
 license = MIT
 license = MIT
 copyright_holder = Troglodyne LLC
 copyright_holder = Troglodyne LLC

+ 1 - 1
package.json

@@ -6,7 +6,7 @@
   "private": true,
   "private": true,
   "dependencies": {
   "dependencies": {
     "express": "^4.17",
     "express": "^4.17",
-    "playwright": "^1.32.3",
+    "playwright": "^1.40.1",
     "uuid": "^8.3"
     "uuid": "^8.3"
   }
   }
 }
 }

+ 5 - 0
playwright_server

@@ -218,6 +218,11 @@ app.post('/command', async (req, res) => {
                 commandResult._guid = 'Download@' + uuidv4();
                 commandResult._guid = 'Download@' + uuidv4();
                 commandResult._type = 'Download';
                 commandResult._type = 'Download';
             }
             }
+            // XXX Console logs too
+            if (command == 'waitForEvent' && commandResult._event && commandResult._event.type == 'log') {
+                commandResult._guid = 'ConsoleMessage@' + uuidv4();
+                commandResult._type = 'ConsoleMessage';
+            }
             // XXX I think you are starting to see a pattern here
             // XXX I think you are starting to see a pattern here
             if (commandResult && commandResult._initializer && commandResult._initializer.fetchUid) {
             if (commandResult && commandResult._initializer && commandResult._initializer.fetchUid) {
                 commandResult._guid = 'FetchResponse@' + uuidv4();
                 commandResult._guid = 'FetchResponse@' + uuidv4();